This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Improve error handling when retrieving all detectors #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
added
the
enhancement
| console.log( | ||
| 'Anomaly detector - Unable to retrieve detector state', | ||
| err | ||
| return Promise.reject( |
There was a problem hiding this comment.
I would prefer you log the err. Same for below changes.
There was a problem hiding this comment.
Sure, I can add in more error logs. The way it is currently implemented, there will still be an error log when the thrown errors get caught in the outermost catch() block of the function.
yizheliu-amazon
approved these changes
Aug 4, 2020
ylwu-amzn
approved these changes
Aug 4, 2020
This was referenced Aug 5, 2020
yizheliu-amazon
pushed a commit
that referenced
this pull request
Aug 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR improves error handling in a few different places regarding retrieving all detectors from ES. Specifically:
could not retrieve property state from undefined).Confirmed basic functionality of plugin works, and all UT/IT pass.
Screenshots:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.